PostHog/posthog

Bug: Type filtering insights is not displaying the correct insights

Open

#25941 opened on Oct 31, 2024

View on GitHub
 (2 comments) (2 reactions) (0 assignees)Python (16,704 stars) (988 forks)batch import
bugfeature/saved-insightsgood first issueteam/product-analytics

Description

Bug description

When viewing all insights, selecting the type of insight does not seem to correctly filter, with incorrect results being shown and insights missing.

How to reproduce

  1. Select Product Analytics and make sure "All insights" is selected.
  2. (Optional) Select a value for "On dashboard: filter"
  3. Verify you can see insights, and their type
  4. Select a dashboard type, for example "Trends"
  5. The results shown do not contain the correct matches, with insights missing

CleanShot 2024-10-31 at 15 24 32

CleanShot 2024-10-31 at 15 25 54

Additional context

From https://posthoghelp.zendesk.com/agent/tickets/20026

Debug info

Organization ID: 0191a3cc-8904-0000-9962-7dd2da597b12
Admin Panel: https://us.posthog.com/admin/posthog/organization/0191a3cc-8904-0000-9962-7dd2da597b12/change/
PostHog Session Replays: https://us.posthog.com/project/2/person/#activeTab=sessionRecordings

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactTypeScriptPostHog insights basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate how the insight type filter interacts with the list of insights. Likely the issue is in the frontend components handling the filter state and making API requests. Look at the 'InsightList' component and the filter logic. Check the network requests to see if the correct query parameters are sent. Also review recent changes to the filtering code.