Restore `scorp → s_corp_income` mapping (revert #1051's change back to the pe-us #8613 leaf)

Open Beginner friendly

#1,055 opened on Jul 5, 2026 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 75/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Quiet
Tech stack: python
Domain: backend

Research direction

Start in variable_mappings.yaml and inspect the two mapper paths mentioned in the issue, along with the surrounding scorp and s_corp_income mappings. Restore the mapping to the dedicated leaf, then verify the scorp and scorp + pbusinc cases produce the stated QBID and retain identical federal, CA, and eCPS results.

Written by the indexing model from the issue text.

Description

#1051 changed scorp → partnership_s_corp_income, which reverted #1042 (scorp → s_corp_income, mapped to the dedicated S-corp leaf split out in pe-us #8613). #1051's rationale — "holding the leaf suppressed QBID" — only applied with the qualified_business_income holdout present, which #1051 itself removed.

Verified: once #1051's holdout fix is in place, scorp → s_corp_income yields the correct QBID (16,850, including the scorp + pbusinc case), with identical federal/CA/eCPS results. So the revert is unnecessary and mapping to the parent (partnership_s_corp_income) risks leaving the s_corp_income leaf unpopulated for any state calc that references it specifically.

Fix: map scorp → s_corp_income (one line in variable_mappings.yaml + the two mapper paths), restoring the #1042/#8613 coordination. Low priority — empirically harmless — but keeps the leaf correct. From the #1051 review.

Dominant language: Python
Stars: 17
Forks: 10
Avg merge: 15h 55m
Merged PRs (30d): 1

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.