PokemonGoF/PokemonGo-Bot

TODO: New evolutions - changes required and help needed

Open

#5922 opened on Feb 19, 2017

View on GitHub
 (30 comments) (0 reactions) (0 assignees)Python (3,816 stars) (1,628 forks)batch import
Feature RequestHelp WantedNew Functionality

Description

Together with 0.57 we have new Pokemons released. This includes movesets and new evolutions. Now it is possible, that some pokemons can evolve to another (previously not available) Pokemons. Some of these evolution, requires a new item(s) : stones.

With 0.57 these new items has been added to the game:

  • 1101: Sun Stone
  • 1102: Kings Rock
  • 1103: Metal Coat
  • 1104: Dragon Scale
  • 1105: Upgrade

Currently bot knows about these new items, but it not aware, about evolution with them. So we have a challenges:

  1. Decide (by config? ) which evolution to take, if candies/stones requirements are met : evolve to Pokemon which doesn't require stone or to this one, which requires stone/rock ?
  2. Check if requirements are met. This can be done by hardcoding stones/rock in evolution logic, or by changing pokemon.json file (by moving NextEvolutionRequirements to Next Evolotuions/Pokemon )
  3. Changing pokemon.json will have a bigger impact on code change

We are open to suggestions and PRs around that. :-)

Contributor guide

Tech stack
python
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
understanding of Pokemon evolution mechanicsPython programmingJSON config structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Review the existing evolution logic in the codebase, likely in files handling Pokemon evolution and the pokemon.json configuration. Examine comments in issue #5922 for suggested approaches, especially regarding moving NextEvolutionRequirements to a per Pokemon structure. Consider the trade offs between hardcoding stones in evolution logic versus modifying pokemon.json, and evaluate the impact on existing code.