PokeAPI/pokeapi

100% female pokemon sprites should be listed under front_female instead of front_default

Open

#271 opened on Oct 18, 2016

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Python (5,191 stars) (1,128 forks)user submission
help wanted

Description

There are some pokemon that have a 100% female gender rate. It would make more sense if their sprites were listed under the sprites/front_female URI. Right now they are listed under the sprites/front_default URI. For instance, the Jynx species is all female. Below is the sprite resource.

sprites: {
    back_female: null,
    back_shiny_female: null,
    back_default: "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/back/124.png",
    front_female: null,
    front_shiny_female: null,
    back_shiny: "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/back/shiny/124.png",
    front_default: "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/124.png",
    front_shiny: "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/shiny/124.png"
}

As you can see. The URL for front_female is null, which is where I believe the resource should be.

Contributor guide

Tech stack
pythonrest api
Domain
backenddataapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic PythonREST API concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the PokeAPI data generation code to understand how sprite URLs are assigned. Focus on the logic that determines which sprite field (front default vs front female) a URL is placed into. Check if there is a gender ratio attribute that can be used to redirect 100% female species. Look at the comments on this issue (#271) for additional context and possibly maintainer guidance.