PokeAPI/pokeapi

100% female pokemon sprites should be listed under front_female instead of front_default

Open

#271 opened on Oct 18, 2016

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Python (1,128 forks)user submission
help wanted

Repository metrics

Stars
 (5,191 stars)
PR merge metrics
 (Avg merge 5d 14h) (26 merged PRs in 30d)

Description

There are some pokemon that have a 100% female gender rate. It would make more sense if their sprites were listed under the sprites/front_female URI. Right now they are listed under the sprites/front_default URI. For instance, the Jynx species is all female. Below is the sprite resource.

sprites: {
    back_female: null,
    back_shiny_female: null,
    back_default: "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/back/124.png",
    front_female: null,
    front_shiny_female: null,
    back_shiny: "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/back/shiny/124.png",
    front_default: "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/124.png",
    front_shiny: "https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/shiny/124.png"
}

As you can see. The URL for front_female is null, which is where I believe the resource should be.

Contributor guide

Research direction
Find where sprite URLs are assigned for Pokémon with 100% female gender rates. Likely in the data generation scripts. Update so that front female contains the sprite and front default is null for such Pokémon.
Tech stack
pythonrest api
Domain
apibackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonREST API basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70