PojavLauncherTeam/PojavLauncher

[BUG] Pause on Lost Focus setting is ignored

Open

#6,196 opened on Oct 24, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (5,279 stars) (1,149 forks)batch import
bughelp wantedwell written

Description

Describe the bug

The vanilla "pause on lost focus" setting is ignored when the app is backgrounded. This means things like AFK farms that require a button to be held down (such as Tree farms or AFK Fish farms, or walking while AFK) cannot be done in the background. A key can be held in the background either with a toggleable button, or with the F3+T trick. However, the actions stop as soon as the activity is in the background.

The log file and images/videos

latest.log

Steps To Reproduce

1. Launch a 1.21.1 instance
2. Enter a singleplayer world
3. Disable Pause on Lost Focus (F3+P)
4. Background the app (without pausing or opening your inventory)
5. Return to the app, see that it is now paused.
6. You can also place down, say, a Noteblock and Button, toggle Right-click, and hear that the dinging stops in the background.

Expected Behavior

The app should be able to enter the background without an Escape key event being sent to the game.

Platform

- Device model: moto G(7)
- CPU architecture: arm64
- Android version: 13
- PojavLauncher version: foxglove-20240922-a6a6a29-v3_openjdk

Anything else?

No response

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaAndroid SDKAndroid Activity lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the Android activity's onPause and onResume methods to see how the 'pause on lost focus' setting affects the game loop. Check for any code that unconditionally sends an Escape key event on background. Look at the related GitHub comments for potential clues. Consider testing with the latest version.