PojavLauncherTeam/PojavLauncher

[BUG] Crash when disconnecting controller during save and quit

Open

#6,164 opened on Oct 11, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Java (5,279 stars) (1,149 forks)batch import
bughelp wantedwell written

Description

Describe the bug

Disconnecting the controller too soon while the game/app is loading after hitting 'save and quit' from ingame results in a crash.

The log file and images/videos

latestcrash.txt latestlog.txt

Steps To Reproduce

Using Modpack: https://www.curseforge.com/minecraft/modpacks/tekkit-remastered with Optifine 1.12.2 HD_U_G5 installed manually via mods folder in custom instance.
Controller: GameSir X2S USB-C in HID mode.

1. Start PoJavLauncher
2. Start Minecraft and connect USB-C controller 
3. Open a world
4. ESC menu > Save and Quit
5. Immediately disconnect controller before main menu loads
6. crash

Expected Behavior

No crash occurs when disconnecting the controller at that time.

Platform

- Device model: sofiap_retail Moto G Stylus (XT2043-4)
- CPU architecture: arm64-v8a
- Android version: 11
- PojavLauncher version: oxglove-20240922-a6a6a29-v3_openjdk

Anything else?

No response

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaAndroid developmentbasic understanding of input handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the controller input handling code, likely in Android specific files. The crash log (latestcrash.txt) should indicate a null pointer or similar. Look for places where a controller disconnection event triggers an action while the game is transitioning between states (e.g., save and quit). Consider adding null checks or proper synchronization to prevent the crash. The repository uses Java and Android APIs; focus on the part that manages controller lifecycle and game state.