PointCloudLibrary/pcl

openni_wrapper::DeviceXtionPro::getCurrentImage returns null pointer?

Open

#681 opened on May 19, 2014

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (4,506 forks)batch import
effort: trivialgood first issuekind: todomodule: io

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (Avg merge 8d 7h) (3 merged PRs in 30d)

Description

Not sure if this is necessarily wrong, but why do we have

boost::shared_ptr<openni_wrapper::Image> 
openni_wrapper::DeviceXtionPro::getCurrentImage (boost::shared_ptr<xn::ImageMetaData>) const throw ()
{
  return (boost::shared_ptr<Image> (reinterpret_cast<Image*> (0)));
}

when for the other devices we return an actual image:

boost::shared_ptr<openni_wrapper::Image> 
openni_wrapper::DevicePrimesense::getCurrentImage (boost::shared_ptr<xn::ImageMetaData> image_data) const throw ()
{
  return (boost::shared_ptr<openni_wrapper::Image> (new ImageYUV422 (image_data)));
}

Contributor guide

Research direction
Investigate why DeviceXtionPro returns a null pointer instead of an actual image, comparing with the PrimeSense implementation to implement a proper image wrapper.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++OpenNI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55