PointCloudLibrary/pcl

Windows all-in-one installer only does a partial install when used in silent mode.

Open

#5,216 opened on Apr 1, 2022

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (9,023 stars) (4,506 forks)batch import
good first issueneeds: author replyplatform: windows

Description

Describe the bug

Windows all-in-one installer only does a partial install when used in silent mode.

Context

I am running allinoneinstaller.exe /S /D=C:/where/I/want/pcl in a CI/CD (GitHub actions, but should not matter).

Expected behavior

I expect everything to be installed, including third-party packages, cmake files, etc. Just as would happen if I run the allinone installer interactively.

Current Behavior

Only bin, lib and include are installed.

To Reproduce

Download the all-in-one installer and run with the command line above. May need to be done in an Administrator cmd/pwsh/bash.

Additional context

Maybe there are command-line switches I should pass to the NSIS installer, to make it select all options? But if there are it seems they are not documented anywhere. I found the /S and /D options on the nullsoft website, but if there are pcl-specific options needed for a full install I have not been able to find them.

I have also tried using the vcpkg installer to install libpcl into the CI/CD, but that fails with one of the dependencies (I think boost), in addition to taking literally hours of runtime.

Contributor guide

Tech stack
cppshell
Domain
devopstooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Knowledge of NSIS installer scriptingFamiliarity with Windows installersAccess to a Windows machine for testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the NSIS installer script in the repository (likely named 'installer.nsi' or similar) to understand how components are defined. Identify which sections or components are not being included when the installer runs with the /S flag. Test by adding 'SectionIn' directives or ensuring all components are selected in silent mode. Also check the NSIS documentation for component selection options. The goal is to modify the script so that all components (including third party packages, cmake files) are installed silently.
Windows all-in-one installer only does a partial install when used in silent mode. · PointCloudLibrary/pcl#5216 | Good First Issue