PointCloudLibrary/pcl

Add Dockerfile (and image) for clang-tidy CI

Open

#4,641 opened on Mar 10, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (9,023 stars) (4,506 forks)batch import
effort: mediumgood first issuekind: todomodule: ci

Description

Image can be based off the pointcloudlibrary/env and add it and clang-tidy (version dependent on the github workflow)

IIRC, doesn't clang-tidy require all dependencies to be installed?

Ahh, that might be. I'm not that familiar with clang/tidy.

I can see Cmake is run as well, which will fail with missing dependencies.

Originally posted by @larshg in https://github.com/PointCloudLibrary/pcl/pull/4636#issuecomment-795061118

Contributor guide

Tech stack
cppdockergithub actions
Domain
ci cddevopsinfrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Docker basicsC++ build system understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests a Dockerfile based on the existing `pointcloudlibrary/env` image, adding clang tidy for CI. Review the linked PR #4636 and the comment about dependencies (https://github.com/PointCloudLibrary/pcl/pull/4636#issuecomment 795061118). Investigate the content of the `pointcloudlibrary/env` image and how clang tidy is installed. Determine if all dependencies are needed for clang tidy to run properly. Look at existing CI workflow files to understand the setup.