PointCloudLibrary/pcl

[custom] Remove empty destructors and constructors

Open

#4,283 opened on Jul 20, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (9,023 stars) (4,506 forks)batch import
effort: lowgood first issuekind: todo

Description

This issue is to split PR #4249 into smaller pieces.

Per @SergioRAgostinho

With destructors I use the following policy:

if your class defines virtual methods which it defines (literally defining, not overriding), I explicitly default it. The compiler throws warnings telling if of your class has virtual methods but the destructor is not virtual.

If a class has empty / default destructors I just remove those lines of code. If the destructor is not implicitly generated you'll get a compiler error, so there's no chance you'll mess up.

For constructors: remove all default constructors unless there's a user defined (non-default) constructor.

From @kunaltyagi: https://godbolt.org/z/8f99dG

Contributor guide

Tech stack
cpp
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ basicsunderstanding of class lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
This issue is part of splitting PR #4249. The policy is: remove empty destructors unless the class defines virtual methods (then default it), and remove default constructors unless a non default constructor is defined. See the godbolt link https://godbolt.org/z/8f99dG for verification. Start with a single file or module, make changes, and compile to ensure no errors.