PointCloudLibrary/pcl

Access to `points` should be suppressed in PCL code

Open

#4,213 opened on Jun 23, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (4,506 forks)batch import
effort: mediumgood first issuekind: todopriority: gsoc

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (Avg merge 8d 7h) (3 merged PRs in 30d)

Description

Access to points can also be suppressed in a lot of places.

Originally posted by @SergioRAgostinho in https://github.com/PointCloudLibrary/pcl/pull/4190

My observations:

points usage can be removed in following ways:

  • replace with functions like: copyPointCloud instead of copyPoint
  • replace with functions like isNormalFinite
  • replace points. to use functions of PointCloud

#4217, #4218, #4219, #4221 tackle third type to a large extent

Contributor guide

Research direction
Identify locations in PCL code where direct access to the 'points' member is used and replace them with equivalent functions like copyPointCloud, isNormalFinite, or PointCloud member functions.
Tech stack
cpp
Domain
computer graphics
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70