PointCloudLibrary/pcl

In preparation for `index_t`, the cast needs to be removed

Open

#4,212 opened on Jun 23, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (4,506 forks)batch import
effort: mediumgood first issuekind: todoneeds: pr mergepriority: gsoc

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (Avg merge 8d 7h) (3 merged PRs in 30d)

Description

In preparation for index_t, the cast either needs to be removed or it needs to be set explicitly to index_t. I vote for removal unless it's unsupported.

Originally posted by @SergioRAgostinho in https://github.com/_render_node/MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDQ0NDE1MTE1NQ==/comments/review_comment

Needs CI run on the PR resolving this issue post #4198 merge

Contributor guide

Research direction
Examine the code where the cast appears and remove it, ensuring compatibility with index t.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70