PointCloudLibrary/pcl

[apps] Convert macro to lambda and fix the call-sites

Open

#3,897 opened on Apr 8, 2020

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C++ (4,506 forks)batch import
changelog: enhancementeffort: lowgood first issuekind: todomodule: apps

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (Avg merge 8d 7h) (3 merged PRs in 30d)

Description

Convert macro FPS_CALC to lambda and fix the call-sites.

Locations:

  • apps/include/pcl/apps/manual_registration.h
  • apps/include/pcl/apps/openni_passthrough.h
  • apps/include/pcl/apps/pcd_video_player.h
  • apps/include/pcl/apps/timer.h

Originally posted by @kunaltyagi in https://github.com/PointCloudLibrary/pcl/pull/3885

Contributor guide

Research direction
Read the macro definition, understand its usage, and create a lambda that can be used similarly. Update all call sites in the listed files to use the lambda instead of the macro.
Tech stack
cpp
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80