PointCloudLibrary/pcl

[PCL] Use C++11 random generators, not `rand`

Open

#3,781 opened on Mar 23, 2020

View on GitHub
 (7 comments) (0 reactions) (0 assignees)C++ (4,506 forks)batch import
effort: mediumgood first issuekind: todo

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (Avg merge 8d 7h) (3 merged PRs in 30d)

Description

Context

rand has several issues, which C++11 random generators don't. New PR often see the rand usage and try to emulate the wrong behavior.

Expected behavior

Remove all rand so when people search for how PCL did its random num generation, they get good quality results

Additional context

Usage of old-fashioned rand discovered by codacity (or maybe try grep)

Contributor guide

Research direction
Search the entire codebase for usage of `rand` and replace with C++11 `<random>` utilities like `std::default random engine` and `std::uniform int distribution`. Ensure consistency across headers and source files.
Tech stack
cpp
Domain
computer graphics
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++C++11 random library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60