PointCloudLibrary/pcl

Check if read succedded before reading again/allocating memory

Open

#3,606 opened on Jan 29, 2020

View on GitHub
 (16 comments) (0 reactions) (0 assignees)C++ (4,506 forks)batch import
good first issuehelp wantedkind: bugneeds: pr merge

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (Avg merge 8d 7h) (3 merged PRs in 30d)

Description

Your Environment

  • PCL Version: HEAD

Context

Bad parsing is inevitable, specially if operations are performed on read data without validation

Expected Behavior

Graceful error detection

Current Behavior

Files: 273 instances. One sample provided:

Possible Solution

Sanity checks on input stream after reading before allocating memory

Contributor guide

Research direction
Identify all locations in the codebase where stream reading is performed without checking if the read succeeded, then add validation before using the read data. Start with the sample file: features/src/narf.cpp line 576.
Tech stack
cpp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitC++PCL basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70