PointCloudLibrary/pcl

Update CMake scripts in tutorials (remove superfluous include_directories et al. calls)

Open

#2,607 opened on Nov 9, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (4,506 forks)batch import
good first issuekind: todomodule: tutorialsskill: cmake

Repository metrics

Stars
 (9,023 stars)
PR merge metrics
 (Avg merge 8d 7h) (3 merged PRs in 30d)

Description

I was thinking about the CMakeLists in tutorials, do they need to be updated as well? My conclusion was no, not yet. It should still be possible to use PCL in downstream projects with old CMake. But once we switch to C++14 we should consider bumping version there and requesting CXX_14 explicitly.

Originally posted by @taketwo in https://github.com/PointCloudLibrary/pcl/pull/2605#issuecomment-437301261

Contributor guide

Research direction
Identify all tutorial CMakeLists.txt files in the repository and update them to use modern CMake (target include directories, target link libraries, etc.) instead of deprecated calls like include directories.
Tech stack
cpp
Domain
build system
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CMake
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70