PointCloudLibrary/pcl

Use strongly typed 'enum' instead of 'int' for properties in PCLVisualizer code

Open

#1,692 opened on Aug 24, 2016

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C++ (9,023 stars) (4,506 forks)batch import
effort: lowgood first issuekind: todomodule: visualization

Description

Right now functions like setPointCloudRenderingProperties use an int to represent the property to be modified. This means that there is no way of knowing which properties are accepted by the function. A solution is to use strongly typed enum instead of int for properties. The issue was brought up in #1668.

Contributor guide

Tech stack
cpp
Domain
api
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic C++ knowledgeUnderstanding of enums
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the PCLVisualizer code, specifically the 'setPointCloudRenderingProperties' function and related rendering property definitions. Look at the discussion in issue #1668 for context. The change involves replacing integer constants with a strongly typed enum; identify all functions where 'int' is used for properties and ensure the enum covers all existing constants. The new enum should be defined in an appropriate header file and the functions updated accordingly.