PointCloudLibrary/pcl

Detect Ensenso version at PCL configuration

Open

#1394 opened on Oct 22, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C++ (9,023 stars) (4,506 forks)batch import
good first issuekind: todomodule: cmakeskill: cmake

Description

There should be a minimum Ensenso version in PCL config to make sure users don't have an old EnsensoSDK installed.

On Linux platforms there is a CMake and pkgconfig files installed (SDK 1.3.146 and above) but not on Windows.

$ pkg-config --modversion ensenso-nxlib
1.3.167

See https://github.com/PointCloudLibrary/pcl/issues/1200#issuecomment-150162667 for a multi-platform method; but there's no such macro in the EnsensoSDK:

$ grep -i "1.3.167" /opt/ensenso/ -r
/opt/ensenso/pkgconfig/ensenso-nxlib.pc:Version: 1.3.167
/opt/ensenso/pkgconfig/ensenso-nxlibremote.pc:Version: 1.3.167
/opt/ensenso/manual/html/changelog.htm:<td style="vertical-align:top; width:333px; padding:0px;"><p>1.3.167</p>
/opt/ensenso/manual/html/changelog.htm:<td style="vertical-align:top; width:120px; padding:0px;"><p>1.3.167</p>
/opt/ensenso/manual/html/zoom_index.js: "1.3.167 65 8 64",
/opt/ensenso/manual/html/zoom_pageinfo.js:["changelog.htm","About &#62; Changelog","About Changelog Navigation: About Changelog EnsensoSDK Revision 1.3.167 Last edited 21.08.2015 Changelog Version Changes 1.3.167 Fix: NxView: Adde...",""],

Contributor guide

Tech stack
cpp
Domain
build system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic CMakepkg configReferenced issue #1200 method
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the multi platform method referenced in issue #1200 comment. Check current PCL CMake files for Ensenso SDK detection. Implement a minimum version check using pkg config on Linux and a fallback for Windows. The SDK version is available in the .pc file on Linux; for Windows, consider parsing a header or using a registry key. Update the CMake configuration to error if the version is below a threshold.