vlsr prior is too narrow

Open
#33 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
data

Research direction

Start by locating fit_map() and inspect how the ±10 km/s vlsr prior is defined and applied. Compare that assumption with the disc cases affected by the issue, then add coverage showing that fitting is no longer excluded by an overly narrow prior; the appropriate replacement range is not specified here.

Written by the indexing model from the issue text.

Description

I think the prior used by fit_map() for vlsr of +-10km/s is too narrow and incompatible with some discs.

Dominant language
Python
Stars
23
Forks
10
Avg merge
28m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PlanetFormationLab/eddy

All issues in PlanetFormationLab/eddy

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.