Picolab/pico-engine

We ought to consolidate code in Wrangler for computing a URL given an absoluteURL and a RID

Open

#583 opened on Jan 7, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (10 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (51 stars)
PR merge metrics
 (PR metrics pending)

Description

To install a ruleset, you have two options:

  1. Provide the absolute (full) URL of where the source code is located, or
  2. Provide an absolute URL of an already-installed ruleset (usually the one that is evaluating) and the RID of another ruleset whose source code is located in the same folder (see RFC-3986, section 4.2)

As Wrangler is written now, there are two places where we compute an absolute URL from a given URL and a RID. These are:

  1. The rule install_ruleset_relatively here, which I view as the "official" place
  2. The rule initialize_child_after_creation here, which should be changed in lines 410-411 to raise the same event but with different attributes

Contributor guide

Research direction
Identify the two code locations that compute absolute URL from a URL and RID, and consolidate them into a single reusable function.
Tech stack
typescript
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitKRL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40