Picolab/pico-engine

developer UI should not allow some picos to be deleted

Open

#495 opened on Dec 17, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (10 forks)auto 404
1 - Readybugdocumentationgood first issue

Repository metrics

Stars
 (51 stars)
PR merge metrics
 (PR metrics pending)

Description

Quoting from our documentation, "Currently, the UI does not allow you to delete a pico which has children (until you first delete all of its children, etc. recursively)."

We need to make this so.

While the engine can just up and delete an entire sub-tree of picos, we don't want this available from the UI. Such a thing should only be done programmatically, and is in the province of Wrangler.

What's asked for here is a simple UI change to not present the "delete" link for a pico that has any children.

Contributor guide

Research direction
Identify where the delete button is rendered in the UI code and add a condition to check if the pico has children before showing the button. Use the existing API or data model to determine child status.
Tech stack
typescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90