PhyberApex/kuroshiro

refactor(api): ScreensService.add complexity and duplicated screen lookup

Open

#852 opened on Aug 22, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (0 forks)auto 404
fallowgood first issueready-for-agent

Repository metrics

Stars
 (10 stars)
PR merge metrics
 (Avg merge 3d 2h) (92 merged PRs in 30d)

Description

Problem Statement

packages/api/src/screens/screens.service.ts:

  • add (line 34): cyclomatic 16, cognitive 18, 71 lines — high (fallow health)
  • Clone group: delete (116-121) and updateExternalScreen (180-185) both do "find screen with device relation, warn + NotFoundException('Screen not found')".

Solution

  • Extract private async findScreenWithDevice(id): Promise<Screen> that throws the NotFoundException, and use it from delete, updateExternalScreen and any other method doing the same lookup.
  • Split add into the branches it handles (upload vs external link vs plugin/mashup source) as private methods so the public method is a dispatcher.
  • screens/__test__ specs stay green.

Verification

  • pnpm lint && pnpm type-check && pnpm test pass
  • Run pnpm fallow:baseline in the same PR so the finding disappears from .fallow-baselines/, then confirm pnpm fallow:ci passes. Never add new findings to a baseline; see docs/agents/fallow.md.

Found by the initial fallow scan (pnpm fallow) on 2026-08-22 and baselined so CI stays green until this is fixed.

Contributor guide

Research direction
Explore the ScreensService class in packages/api/src/screens/screens.service.ts. Understand how add, delete, and updateExternalScreen work, and note the duplicated screen lookup. Look at the existing tests in screens/ test to see expected behavior. Then plan how to extract a private findScreenWithDevice method and break add into smaller methods.
Tech stack
nodejstypescript
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80