PathOfBuildingCommunity/PathOfBuilding

Add support for stages on certain vaal skills

Open

#5,698 opened on Feb 19, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Lua (2,318 forks)batch import
enhancementgood first issue

Repository metrics

Stars
 (5,224 stars)
PR merge metrics
 (Avg merge 8h 37m) (1 merged PR in 30d)

Description

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Vaal Blight, Vaal Reave and Vaal blade flurry are missing stages. image image image

Describe the solution you'd like

Them to have stage support

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Research direction
Find the skill definitions for Vaal Blight, Vaal Reave, and Vaal Blade Flurry in the game data files. Look at how other skills, like Vaal Cyclone or normal Blight, implement stage support. Likely the stage mechanic is missing from the skill gem definition or the skill's mods. Check the 'gemList.lua' or similar files for skill data and ensure stage related mods are present.
Tech stack
lua
Domain
desktopbackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
LuaPath of Exile game knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60