PathOfBuildingCommunity/PathOfBuilding

Add support for stages on certain vaal skills

Open

#5,698 opened on Feb 19, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Lua (5,224 stars) (2,318 forks)batch import
enhancementgood first issue

Description

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Vaal Blight, Vaal Reave and Vaal blade flurry are missing stages. image image image

Describe the solution you'd like

Them to have stage support

Describe alternatives you've considered

No response

Additional context

No response

Contributor guide

Tech stack
lua
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of PathOfBuilding skill data structuresFamiliarity with Lua tables
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine how stages are implemented for similar Vaal skills (e.g., Vaal Ice Nova) in the skill gem data files. Look in the repository's Lua source for skill definitions. Add stage support for Vaal Blight, Vaal Reave, and Vaal Blade Flurry by modifying their data structures to include a 'stages' field, mirroring the pattern used for other skills. No linked PRs or comments provide additional guidance.