PathOfBuildingCommunity/PathOfBuilding

Other avoidance/crit reduction suggests crit chance reduction when it's extra damage reduction

Open

#5,417 opened on Dec 20, 2022

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Lua (5,224 stars) (2,318 forks)batch import
bug: accuracygood first issue

Description

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

What is the wording ingame?

Reduced extra damage from critical strikes (Watcher's eye).

What is the wording in Path of Building?

Crit reduction This suggests reduction of enemy crit chance.

The true source of enemy critical strike reduction is Defiance banner which is not listed here. I believe crit reduction should list defiance banner (and other possible sources of crit chance reduction) and the watcher's eye should be listed as crit extra reduction (or something along those lines).

Character build code

No response

Screenshots

No response

Contributor guide

Tech stack
lua
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Lua knowledgefamiliarity with Path of Building UI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look for the string 'Crit reduction' in the Lua source code, likely in a localization or stat description file. The correct label should differentiate between 'Extra damage reduction from crits' (Watcher's Eye) and 'Crit chance reduction' (Defiance banner). Update the label accordingly. Check existing PRs or comments for guidance.