PathOfBuildingCommunity/PathOfBuilding

Arcane cloak breaks a lot of calculations if used with negative unreserved mana

Open

#5,411 opened on Dec 19, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Lua (5,224 stars) (2,318 forks)batch import
bug: calculationgood first issue

Description

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Check for support

  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the value from the calculation ingame?

If you have "negative reservation" it should simply acts as consuming 0 mana rather than a negative amount.

What is the value from the calculation in Path of Building?

It assume negative mana breaking damage and max hit calculations image

How to reproduce the issue

Reserve more than 100% of mana See broken calculations

Character build code

https://poe.ninja/pob/Mi1

Screenshots

No response

Contributor guide

Tech stack
lua
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Lua programmingPath of Exile game mechanics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
The bug occurs with Arcane Cloak causing negative unreserved mana. The fix should clamp negative mana reservation to zero before calculations. Investigate the mana reservation code in the 'calc' or 'data' modules, such as functions computing unreserved mana. Look at the Arcane Cloak implementation and how negative values propagate to damage and max hit calculations.