PathOfBuildingCommunity/PathOfBuilding

Dread and War banner are missing base flags

Open

#5,125 opened on Oct 2, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Lua (2,318 forks)batch import
buggood first issue

Repository metrics

Stars
 (5,224 stars)
PR merge metrics
 (Avg merge 8h 37m) (1 merged PR in 30d)

Description

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

Them to have base flags which will allow them to have a duration shown.

What is the actual behaviour/value?

image image image image

How to reproduce the issue

No response

Character build code

https://pobb.in/U7tUNamjxz1Y

Screenshots

No response

Contributor guide

Research direction
Inspect the skill definitions for Dread and War banners in the Lua data files (likely under src/Data/Skills or similar). Look for missing 'baseFlags' or 'duration' fields. Check how other banner skills (like Blood and Sand) define baseFlags, and add the missing flags to ensure duration is displayed.
Tech stack
lua
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
LuaPath of Exile game knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70