PathOfBuildingCommunity/PathOfBuilding

Dread and War banner are missing base flags

Open

#5,125 opened on Oct 2, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Lua (5,224 stars) (2,318 forks)batch import
buggood first issue

Description

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

What is the expected behaviour/value?

Them to have base flags which will allow them to have a duration shown.

What is the actual behaviour/value?

image image image image

How to reproduce the issue

No response

Character build code

https://pobb.in/U7tUNamjxz1Y

Screenshots

No response

Contributor guide

Tech stack
None
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Lua knowledgefamiliarity with PoE skills
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the skill data files for Dread Banner and War Banner in the project's data directory, likely under src/Data/Skills/. Look for missing 'baseFlags' or similar fields that control duration display. The bug indicates these flags are absent, so adding them should enable the duration to show. Check similar skills for reference on how flags are defined, then test locally to confirm the fix.