PathOfBuildingCommunity/PathOfBuilding

Add support for a variety of item implicts.

Open

#5,110 opened on Sep 23, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Lua (5,224 stars) (2,318 forks)batch import
enhancementgood first issue

Description

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

image image image image image image image image image image image image image image image

Describe the solution you'd like

Support for as many as reasonable.

Describe alternatives you've considered

Not adding support for some of the more weird ones.

Additional context

No response

Contributor guide

Tech stack
lua
Domain
desktopdata
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
Lua programmingPath of Exile item systemCodebase structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the repository's source code to find where item implicits are defined (likely in data files or Lua scripts). Use the screenshots to identify which implicits are missing. Follow the existing pattern to add the new ones. Verify that the implementation aligns with the game's current mechanics. Consider adding corresponding tests.