PathOfBuildingCommunity/PathOfBuilding

Eldritch Implicit Mods not removed when influence is removed

Open

#4,941 opened on Aug 20, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Lua (5,224 stars) (2,318 forks)batch import
enhancementgood first issue

Description

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Eldritch Implicit Mods not removed when influence is removed

Describe the solution you'd like

Remove the mods tagged with {eater} or {exarch} when the corresponding influence is removed

Describe alternatives you've considered

No response

Additional context

removing the mods when the item loses influence probably has something to do with setDisplayItemInfluence in ItemsTab?

Contributor guide

Tech stack
None
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
LuaPath of Exile item system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue suggests that removing influence should also remove Eldritch Implicit mods tagged with {eater} or {exarch}. The likely location is the setDisplayItemInfluence function in ItemsTab. Investigate how influence is currently removed and where these mods are stored to implement the removal logic.