PathOfBuildingCommunity/PathOfBuilding

Eldritich Mods from imported/copypasted items not being taged correctly and thus not being replaced correctly

Open

#4,940 opened on Aug 20, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Lua (5,224 stars) (2,318 forks)batch import
enhancementgood first issue

Description

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Eldritich Mods from imported/copypasted items not being taged correctly and thus not being replaced correctly

Describe the solution you'd like

mods should get the {eater} or {exarch} tags before them

Describe alternatives you've considered

No response

Additional context

For correctly tagging the mods from imported items, you would have to parse that in parseRaw? from actual import items I guess you do it in https://github.com/PathOfBuildingCommunity/PathOfBuilding/blob/dev/src/Classes/ImportTab.lua#L834-L841 but for copy pasted items that are like "7% Chance to Block Spell Damage (implicit)" and not "{eater} 7% Chance to Block Spell Damage" its probibly done in parseRaw

could do somthing like

local index = nil
for i, implictMod in ipairs(item.implicitModLines) do
      for _, mod in ipairs(modList) do
          for _, modLine in ipairs(mod.mod) do
              if modLine == implictMod.line then
                  index = i
                  break
              end
          end
          if index then
              break
          end
      end
      if index then
          break
       end
end
if index then

Contributor guide