Make main socket group guess more fit for poe2
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
Start at src/Classes/ImportTab.lua lines 1638-1648 and trace the current main socket group guess, then inspect how skill sets and DPS are represented. Done means selecting a useful PoE2 main socket group across different skill sets, including cases such as the Doedre's frog build, rather than relying on group size alone.
Written by the indexing model from the issue text.
Description
Check for duplicates
- I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
The current socket group guess function is obviously mainly meant for PoE1 since it uses the group size, but for PoE2 this isn't really correct since every group can be a 6 link. It would probably be a good idea to choose the main socket group by e.g. DPS, while also going through different skill sets. Especially some builds like the doedre's frog build have a useless curse as the first stat set which seems to confuse people.
Describe the solution you'd like
123
Describe alternatives you've considered
No response
Additional context
No response
- Dominant language
- Lua
- Stars
- 1.9k
- Forks
- 452
- Avg merge
- 21h 16m
- Merged PRs (30d)
- 68
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from PathOfBuildingCommunity/PathOfBuilding-PoE2
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PathOfBuildingCommunity/PathOfBuilding-PoE2#2156 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
PathOfBuildingCommunity/PathOfBuilding-PoE2#1857 · 2 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Difficulty 4/5 3-5 days Newbie friendliness 68/100
All issues in PathOfBuildingCommunity/PathOfBuilding-PoE2
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
api7/lua-resty-saml#62 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nvim-tree/nvim-tree.lua#3357 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 94/100
codymikol/multiverse.nvim#320 ·
-
Data Correction tbc
Difficulty 2/5 1-3 hours Newbie friendliness 68/100