ParadiseSS13/Paradise

Holy minds cant break the `anybody` subtype of soul stones despite being hinted that they can

Open

#27,434 opened on Nov 23, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)DM (445 stars) (1,313 forks)batch import
Good First IssueOversight

Description

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

1645

Issue Description

despite An overwhelming feeling of dread comes over you as you pick up [src]. It looks fragile enough to break with your hands. being put in chat when you pickup any inhabited soul stone, if its the /anybody subtype, you just let the soul out to run around, rather than breaking it.

What did you expect to happen?

to shatter it like you can the normal cult stones

What happened instead?

little guy got let out to run around

Why is this bad/What are the consequences?

its inconsistent, the red soul stones are meant to be able to be shattered. This is a bigger problem with tarot cards existing, if a librarian runs up to someone, does their thing, then shards them, then is caught before they can do anything with it, sec can be confused due to the hints indicating a holy mind being able to break it.

Steps to reproduce the issue.

shard someone with the /anybody stone subtype try to break it as a holy mind(chaplain/paranormal ert)

When did the problem start happening?

i dunno forever probably

Extra information

A "workaround" exists that you can just shoot the stone to break it, or kill the spirit if its out of the stone, but its inconsistent none the less

Relevant log output/runtime error

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with BYOND DM code
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look for the `/anybody` subtype of soul stones in the codebase, likely in `code/game/objects/items/storage/soul stone.dm` or similar. Compare the break behavior for normal cult stones vs the `/anybody` subtype. The issue states that the hint text appears but the action to break is missing. Check the `attack hand` or `attackby` proc for the soul stone item to see why the break action is not triggered for holy minds. The fix likely involves adding a check for the `/anybody` subtype when attempting to break the stone.