ParadiseSS13/Paradise

Chemfridge dispenced pill into disabled arm

Open

#25,433 opened on May 8, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)DM (445 stars) (1,313 forks)batch import
Good First IssueOversight

Description

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

515.1636

Issue Description

When I had my arm disabled from genetics damage, a pill was able to be dispensed into the disabled arm.

What did you expect to happen?

The pill to enter my other hand.

What happened instead?

I got a pill in a disabled arm.

Why is this bad/What are the consequences?

Unintended.

Steps to reproduce the issue.

Disable arm, dispense pill.

When did the problem start happening?

No idea

Extra information

No response

Relevant log output/runtime error

No response

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of DM codebaseAccess to local test server
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue is about a pill being dispensed into a disabled arm. Look for the code that handles pill dispensing, likely in inventory or chemistry related files. Check where the arm status (disabled) is checked before placing the pill. The expected behavior is that the pill should go to the other hand if the targeted arm is disabled. Investigate the conditionals in the dispensing logic and ensure the arm's health is considered.