ParadiseSS13/Paradise

Can not turn off thresholds in Air Alarm UI

Open

#24,643 opened on Mar 16, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)DM (1,313 forks)batch import
Good First IssueOversight

Repository metrics

Stars
 (445 stars)
PR merge metrics
 (Avg merge 13d 5h) (90 merged PRs in 30d)

Description

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

515.1633

Issue Description

Air Alarms' thresholds can not be turned off by setting them to -1.

What did you expect to happen?

Setting thresholds to -1 should turn them off.

What happened instead?

Setting thresholds to -1 clamps it to 0.

Why is this bad/What are the consequences?

Slight inconvenience over setting the threshold to min/max.

Steps to reproduce the issue.

  1. Open an Air Alarm.
  2. Go to Thresholds.
  3. Set one of them to -1.

When did the problem start happening?

Since TGUI Inputs were introduced.

Extra information

https://github.com/ParadiseSS13/Paradise/blob/521abceae83be85905923cb7253c8eb85a3d6bb7/code/modules/atmospherics/machinery/airalarm.dm#L852

Relevant log output/runtime error

No response

Contributor guide

Research direction
Examine the threshold clamping logic in the air alarm code, specifically the line referenced in the issue. Find where 1 is clamped to 0 and modify the condition to allow 1 as a valid off value.
Tech stack
None
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
DMGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75