ParadiseSS13/Paradise

Can not turn off thresholds in Air Alarm UI

Open

#24,643 opened on Mar 16, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)DM (445 stars) (1,313 forks)batch import
Good First IssueOversight

Description

Exploit Reports

  • I confirm this issue is not an exploit. (Required)

BYOND Version

515.1633

Issue Description

Air Alarms' thresholds can not be turned off by setting them to -1.

What did you expect to happen?

Setting thresholds to -1 should turn them off.

What happened instead?

Setting thresholds to -1 clamps it to 0.

Why is this bad/What are the consequences?

Slight inconvenience over setting the threshold to min/max.

Steps to reproduce the issue.

  1. Open an Air Alarm.
  2. Go to Thresholds.
  3. Set one of them to -1.

When did the problem start happening?

Since TGUI Inputs were introduced.

Extra information

https://github.com/ParadiseSS13/Paradise/blob/521abceae83be85905923cb7253c8eb85a3d6bb7/code/modules/atmospherics/machinery/airalarm.dm#L852

Relevant log output/runtime error

No response

Contributor guide

Tech stack
None
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic DM codingFamiliarity with TGUI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look at the code linked in the issue: https://github.com/ParadiseSS13/Paradise/blob/521abceae83be85905923cb7253c8eb85a3d6bb7/code/modules/atmospherics/machinery/airalarm.dm#L852. The issue is that setting thresholds to 1 clamps to 0 instead of turning them off. Investigate the clamping logic in that area to allow 1 as a valid value to disable the threshold. Check how TGUI inputs handle the value and ensure the backend accepts 1.