ParadiseSS13/Paradise

[BUG] pAI Unfolding Saves Their Lives In Disposals Pipes.

Open

#19,414 opened on Oct 16, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)DM (445 stars) (1,313 forks)batch import
Good First Issue

Description

Issue Description:

pAI unfolding through disposal pipes and appearing above ground.

What did you expect to happen:

An individual threw me into disposals while I was in my Collapsed Form as a pAI. While traversing through the Disposal pipes, I decided to press Unfold to see what would happen, thinking I would still continue through the pipes and into disposals...

What happened instead:

... What actually happened is once I hit the Unfold button, I IMMEDIATELY bamphed back up above onto ground-level, completely unscathed and moving around. I pressed the Unfold button while in the pipes leading in a Hallway, so I appeared right above the flooring and in said Hallway.

Why is this bad/What are the consequences:

If somebody is actually attempting to dispose of a pAI through lethal matters via Disposal chute.. This is pretty much a guarantee pAI living if they unfold into their creature form.

Steps to reproduce the problem:

  1. Be a pAI that already has a form prepared (i.e. Cat)
  2. Have a very mad individual toss you into the disposals bin while you are Collapsed Form (box).
  3. Traverse through the pipes...
  4. Press the Unfold button and huzzah! Above ground you are!

When did the problem start happening:

Just found out around 6PM Central Standard Time on 16-10-2022. It still works as of now!

Extra information:

Y'all cute :>

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the pAI code (likely in code/game/objects/items/devices/paicard.dm) and disposal pipe code to find where unfolding is allowed during transit. The bug occurs because the unfold action is not blocked when the pAI is inside a disposal pipe. Add a check to prevent unfolding while the pAI's mob is in a pipe via a location or movement check.