ParadiseSS13/Paradise

Infrared lasers work even in a backpack/locker/etc

Open

#15,958 opened on Apr 28, 2021

View on GitHub
 (2 comments) (0 reactions) (0 assignees)DM (445 stars) (1,313 forks)batch import
BugGood First Issue

Description

Issue Description:

Tripwire laser mines (chem grenades using infrared as detonator) will check in the direction they're set even if they are in a container. Logically, the laser shouldnt pierce through?

What did you expect to happen:

Nothing.

What happened instead:

Tripwire is triggered by somebody walking in front of a locked locker.

Why is this bad/What are the consequences:

Makes it much easier to hide tripwire mines. Not logical.

Steps to reproduce the problem:

  1. Make a tripwire mine chem grenade
  2. Set it to activated, with any direction or invisibility setting
  3. Walk in front of it in the direction set, boom

When did the problem start happening:

Likely long living oversight

Contributor guide

Tech stack
None
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of SS13 object hierarchyBasic knowledge of DM scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Examine the infrared detonator code, likely in `code/game/objects/items/grenades/infrared.dm` or similar. Look for the laser scanning logic that checks line of sight. The fix should add a condition to verify that the mine is not inside a container (e.g., backpack, locker) before triggering. Check the `loc` variable to determine if the item is inside another atom. Reference the issue comments for any additional context.
Infrared lasers work even in a backpack/locker/etc · ParadiseSS13/Paradise#15958 | Good First Issue