POSYDON-code/POSYDON

BinaryStar.reset() fails after setting BinaryStar.properties

Open

#483 opened on Jan 16, 2025

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Python (35 forks)auto 404
help wantedquestion

Repository metrics

Stars
 (42 stars)
PR merge metrics
 (PR metrics pending)

Description

When recreating binary from a dataframe, reset() fails with the following error after setting sim_pop.

B = BinaryStar.from_df(example_binary)
B.to_df()
B.properties = sim_pop
B.reset()

It looks like a value is being set as a float that should have a history.

Removing B.properties = sim_pop allows reset to properly work. How should we approach this issue?

Contributor guide

Research direction
Investigate the `reset()` method in BinaryStar and the `properties` setter. Look for where a float value is assigned without history. Trace the error when `sim pop` is set.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60