POSYDON-code/POSYDON

`find_nearest` in `gridutils`

Open

#465 opened on Dec 5, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (35 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (42 stars)
PR merge metrics
 (PR metrics pending)

Description

find_nearest doesn't use: find_index_nearest_neighbour, which is available.

Additionally, it requires the input to be numpy.array's. Can we change the code function to np.argmin()? And np.abs?

Contributor guide

Research direction
Locate the `find nearest` function in the codebase, understand its current implementation using manual loops, and replace with `np.argmin(np.abs(array value))` to improve performance and remove the requirement for numpy arrays.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75