POSYDON-code/POSYDON

He-rich stars being directed to step_HMS_HMS_RLO

Open

#448 opened on Nov 22, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (35 forks)auto 404
good first issue

Repository metrics

Stars
 (42 stars)
PR merge metrics
 (PR metrics pending)

Description

In the initial_eccentricity_flow_chart, both H-rich and He-rich stars in RLO are being directed to step_HMS_HMS_RLO. However, this step does not actually handle the He-rich stars, it just fails them because they are not in the FOR_RLO_STATES. This should be corrected so that these stars are better handled in the flow, ensuring the changes are also consistent with the error catching for RLO binaries with H-rich stars in the detached step (e.g. PR #430).

Contributor guide

Research direction
Inspect the flow chart logic in initial eccentricity flow chart and ensure He rich stars in RLO are correctly routed to an appropriate step, not step HMS HMS RLO. Verify consistency with PR #430 for H rich stars in detached step.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70