POSYDON-code/POSYDON

Cleanup the order of definitions.

Open

#444 opened on Nov 21, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (35 forks)auto 404
enhancementgood first issuev2 feature

Repository metrics

Stars
 (42 stars)
PR merge metrics
 (PR metrics pending)

Description

Usually, all called should be defined beforehand and not afterwards. An example is posydon.utils.common_functions.Schwarzschild_Radius should be defined before posydon.utils.common_functions.CO_radius

Contributor guide

Research direction
Identify functions that are called before they are defined in POSYDON source files and reorder them so that definitions precede their usage. Use static analysis or manual inspection, focusing on files like posydon/utils/common functions.py.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90