POSYDON-code/POSYDON

NS/WD NaN mass, SN_type & CO_type not consistent

Open

#280 opened on Mar 18, 2024

View on GitHub
 (7 comments) (0 reactions) (3 assignees)Python (35 forks)auto 404
P1 - high priorityenhancementhelp wanted

Repository metrics

Stars
 (42 stars)
PR merge metrics
 (PR metrics pending)

Description

For systems with state=NS and SN_Type=WD, no mass is present in the MODELxx. Is this expected behaviour for the models, when the state and SN type do not match?

Should we recalculate the mass with the state/SN_type based on the preSN model parameters?

STAR1 = SingleStar(**{'mass': 7.592921,
                      'state': 'H-rich_Core_H_burning'})
STAR2 = SingleStar(**{'mass':5.038679 ,
                      'state': 'H-rich_Core_H_burning'})

BINARY = BinaryStar(STAR1, STAR2,
                    **{'time': 0.0, 'state': 'detached', 'event': 'ZAMS', 'orbital_period':5.537807, 'eccentricity': 0.0},
                    properties = sim_pop)
 S1_mass S2_mass S1_he_core_mass S1_co_core_mass S1_state S2_state time state event orbital_period eccentricity
7.592921 5.038679 NaN NaN H-rich_Core_H_burning H-rich_Core_H_burning 0.000000e+00 detached ZAMS 5.537807 0.0
1.229538 5.234164 1.229538 1.120187 stripped_He_Central_He_depleted H-rich_Core_H_burning 5.204840e+07 detached CC1 11.434389 0.0
NaN 5.234164 NaN NaN WD H-rich_Core_H_burning 5.204840e+07 detached NaN 0.0
NaN 5.234164 NaN NaN WD H-rich_Core_H_burning 5.204840e+07 detached NaN 0.0

Contributor guide

Research direction
Examine the code that handles state and SN type to identify why NaN mass occurs when state=NS and SN Type=WD. Consider whether mass should be recalculated based on preSN parameters.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30