PLC-lang/rusty

Hint user that a POU instance is missing

Open

#1,235 opened on Jun 5, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (71 forks)auto 404
good first issuelow-priorityvalidation

Repository metrics

Stars
 (351 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. The following code will return a Could not resolve reference to fn_with_one_parameter error

FUNCTION_BLOCK fn_with_one_parameter
    VAR_INPUT
        in_one : DINT;
    END_VAR
END_FUNCTION_BLOCK

FUNCTION main : DINT
    fn_with_one_parameter(1);
END_FUNCTION

This is because an instance hasn't been declared. Knowing this is a FUNCTION_BLOCK it would be nice to hint the user that they're not dealing with functions and are missing an instance declaration.

Describe the solution you'd like Improve the error message

Contributor guide

Research direction
Investigate the error reporting code in the Rusty parser for POU references, specifically where 'Could not resolve reference' errors are generated. Understand how function blocks and function calls are distinguished. Modify the error message to include a hint about missing instance declarations when a function block is called without an instance.
Tech stack
rust
Domain
compilersdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rustcompilers
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70