PLC-lang/rusty

show warning for BOOL-INT downcast

Open

#1,167 opened on Mar 20, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Rust (71 forks)auto 404
good first issuelow-priorityvalidation

Repository metrics

Stars
 (351 stars)
PR merge metrics
 (PR metrics pending)

Description

the following code

PROGRAM mainProg
VAR
  x1 : BOOL;
  x2 : INT;
END_VAR
  x1 := 20; 
  x2 := TRUE;
END_PROGRAM

will generate no warning, no error!

It will be nice to have minimum a warning and later to adjust easier the error_config file for codesys where this a error is.

Contributor guide

Research direction
Examine the type checking code to find where implicit conversions are handled, and add a warning for BOOL INT downcast assignments.
Tech stack
rust
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75