PLC-lang/rusty

Add validation for comparison operators

Open

#1,026 opened on Nov 23, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Rust (71 forks)auto 404
good first issuemedium-priorityvalidation

Repository metrics

Stars
 (351 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. When trying to compile code with a comparison statement which tries to compare incompatible types, we currently do not validate against it and the compilation will fail during codegen.

FUNCTION main : DINT
        VAR
            x1 : ARRAY[0..2] OF TOD;
            x2 : STRING;
        END_VAR
            x1 > x2;  
            GT(x1, x2);
END_FUNCTION

Describe the solution you'd like We should validate if the two types in the binary expression can be compared to each other

Contributor guide

Research direction
Study the existing type validation for binary expressions in the compiler, particularly the area where operators like > and GT are handled. Look at how type checking is done for other operators and add a check for comparison compatibility.
Tech stack
rust
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70