OrchardCMS/OrchardCore

Problem with counting in the workflow loop

Open

#6,912 opened on Aug 15, 2020

View on GitHub
 (9 comments) (0 reactions) (0 assignees)C# (6,998 stars) (2,288 forks)batch import
good first issue

Description

Look at the pictures of my workflow and I put the data I received The number of rotations of the loop must be one less than the size of my array because I started from zero and in JavaScript the arrays start from zero, but when I The end value ="property('data').Time.length-1", my loop counts one less.

02

Contributor guide

Tech stack
javascript
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
basic JavaScriptfamiliarity with OrchardCore workflows
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the workflow loop counting logic in OrchardCore, particularly the expression 'property('data').Time.length 1'. Review the comments on the issue for any additional context. Look at the workflow module code that evaluates JavaScript in loop conditions. The issue likely involves an off by one error in the loop predicate. Check if there are any existing tests for workflow loops and verify the expected behavior.
Problem with counting in the workflow loop · OrchardCMS/OrchardCore#6912 | Good First Issue