OrchardCMS/OrchardCore

Combine the recipe import (file and JSON) into one

Open

#11,958 opened on Jul 5, 2022

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C# (6,998 stars) (2,288 forks)batch import
Deploymentgood first issue

Description

Is your feature request related to a problem? Please describe.

Currently, the Deployment feature expose 2 different routes to import a recipe. First one using a JSON string, and the other one is using a file. For that reason, we have 2 menu items on the navigation (i.e., JSON Import and Package Import)

Describe the solution you'd like

I think we should replace both menu items (i.e., JSON Import and Package Import) with a single one called "Import Recipes". In the "Import Recipes" view, we can have two radio buttons to select which type of import to

  1. First radio button will be "JSON recipe" which is checked by default. We'll show the JSON input field by default and hide the field upload field.
  2. Second radio button will be "Recipe file". If the user checks this radio, we'll just show the file upload field.

This should reduce the navigation menu by 1 item and centralize the import process.

Contributor guide

Tech stack
csharphtmlcssjavascript
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with Orchard Core admin UI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Start by examining the current import routes in the Orchard Core admin navigation (likely in a menu configuration file or view). The issue suggests combining two menu items ('JSON Import' and 'Package Import') into one 'Import Recipes' view with radio buttons. Look at the existing import controllers/views for JSON and file imports to understand the current implementation. The new view should conditionally display a JSON input field or file upload based on the selected radio button. No linked PRs or additional comments provide further direction, so you may need to ask for clarification on the exact UI framework used (Razor views or Blazor).