Save Focal Gain LUT into a data file (json, csv, etc.) to make the source code file shorter.

Open Beginner friendly
#448 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
build-system

Research direction

Locate the source file containing the Focal Gain lookup table and the packaging configuration with the [tool.setuptools.package-data] section. Read the table via importlib.resources and verify that an installed package can access the bundled data file while preserving the existing lookup behavior.

Written by the indexing model from the issue text.

Description

enhancement

Totally optional but consider saving the lookup table into a data file (json, csv, etc.) to make the source code file shorter.

If you chose to do that:

  • you would read the file here using importlib.resources to locate it
  • you would ensure it's bundled int he install by adding it to the [tool.setuptools.package-data] section. in case hatchling doesn't bnundle it automatically

Originally posted by @ebrahimebrahim in https://github.com/OpenwaterHealth/openlifu-python/pull/443#discussion_r3066545337

Dominant language
Python
Stars
27
Forks
21
Avg merge
1d 20m
Merged PRs (30d)
6

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from OpenwaterHealth/openlifu-python

All issues in OpenwaterHealth/openlifu-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.