OpenwaterHealth/openlifu-python

Overwriting a volume can leave a dangling volume file in the database

Open

#136 opened on Oct 16, 2024

View on GitHubContributor guide
 (2 comments) (0 reactions) (1 assignee)Python (16 forks)auto 404
buggood first issue

Repository metrics

Stars
 (24 stars)
PR merge metrics
 (PR metrics pending)

Description

When using Databse.write_volume if we choose to overwrite an existing volume but use a volume file with a different filename, then the old volume file is left there dangling. (It exists only in the filesystem but it is still there in the database directory taking up space.)

Contributor guide

Research direction
Inspect the `write volume` method in the database module to understand how volume overwrite is handled. Look for code that deletes old volume files when overwriting, and check if the database record is correctly updated to remove the reference to the old file but the file itself might not be deleted. The fix should ensure that when a volume is overwritten with a new filename, the old volume file is removed from the filesystem.
Tech stack
python
Domain
databasebackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75