OpenXRay/xray-16

Compiler warnings elimination

Open

#713 opened on Jan 8, 2021

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C++ (519 forks)auto 404
Code QualityHelp wantedPortability

Repository metrics

Stars
 (3,524 stars)
PR merge metrics
 (PR metrics pending)

Description

Starting from the creation of this task, #116 is a subtask of this task.

MSVC:

  • MSBuild
    • Enable "warnings are errors" mode (is it possible?)
  • Compiler
    • Enable conformance mode
    • Enable "warnings are errors" mode
    • Raise the warning level to 4
      • Level 1
      • Level 2
      • Level 3
      • Level 4
  • Linker
    • Enable "warnings are errors" mode

GCC:

  • CMake and make
    • Enable "warnings are errors" mode (is it possible?)
  • Compiler
    • Disable permissive mode
    • Maybe enable pedantic mode
    • Enable "warnings are errors" mode
    • Raise the warning level to 4
      • Level 1
      • Level 2
      • Level 3
      • Level 4
  • Linker
    • Enable "warnings are errors" mode

For history:

  • List all warnings elimination commits in this issue

Tools: PVS-Studio CppDepend (includes cppcheck, Clang-Tidy, Vera++) ReSharper C++ (includes Clang and Clang-Tidy check plus it's own analysis) Visual Assist (has it's own code inspection)

https://habr.com/ru/articles/75123/ https://habr.com/ru/companies/pvs-studio/articles/303664/

Contributor guide

Research direction
Examine the compiler warning output for each build configuration. Identify the warning codes and flags, then modify the CMakeLists.txt or MSBuild project files to add appropriate compiler flags to enable warnings as errors. Test each build system locally.
Tech stack
ccpp
Domain
build system
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++CMakeMSBuildGCC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40