OpenXRay/xray-16

[Scripting] Invalid sampler referenced in wallmark shader

Open

#374 opened on Mar 23, 2019

View on GitHub
 (8 comments) (0 reactions) (0 assignees)C++ (519 forks)auto 404
BugHelp wantedRenderer

Repository metrics

Stars
 (3,524 stars)
PR merge metrics
 (PR metrics pending)

Description

The effects_wallmark.s defines smp_rtlinear sampler (introduced with fa4fb77bdb45234ed0b95718bdab3ad2d1749188) while binded pixel shader stub_default_ma.ps still referencing the smp_base. Pass compiler skips the sampler resource setup since no mention about smp_rtlinear is present in shader's reflection data. Things work as expected just by a coincidence: the state manager resets all samplers descriptors to default (linear filtering + clamping) before the samplers get updated in accordance to the state parameters.

While fixing this one should consider that thedx10sampler LUA object doesn't expose any methods to control the sampler state. This can be done by using old fashioned sampler instead:

shader : sampler ("smp_base") : clamp() : f_linear()

Is there any chance to know what was wrong with original shader code? If some of the wallmarks was drawn wrapped (this is my guess) we need to check the render code first.

Contributor guide

Research direction
Investigate the wallmark shader script (effects wallmark.s) and the bound pixel shader stub default ma.ps. The issue is a mismatch: the script defines sampler 'smp rtlinear' but the pixel shader expects 'smp base'. The fix involves using the old fashioned 'sampler' method in the shader script to properly control the sampler state, as the dx10sampler LUA object lacks methods for this. Ensure that the sampler binding is corrected and consider whether wallmarks need wrapping, which would require checking the render code.
Tech stack
lua
Domain
desktopcomputer graphics
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++LuaGraphics programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60