OpenXRay/xray-16

Get rid of Loki

Open

#240 opened on Sep 9, 2018

View on GitHub
 (3 comments) (2 reactions) (0 assignees)C++ (519 forks)auto 404
Code QualityExternal (3rd party)Help wantedPortability

Repository metrics

Stars
 (3,524 stars)
PR merge metrics
 (PR metrics pending)

Description

Loki is a C++ library found in the sdk folder. There are several reasons to remove it:

  • Most of the stuff of this library, written for C++98 by Andrei Alexandrescu, can be found in C++11, e.g. Loki::Select is just std::conditional, Loki::IsSameType can be replaced with std::is_same.
  • Some of the code does not compile in GCC. (With some changes, it compiled in GCC)
  • The things that haven't been included in modern C++, can be rewritten with fewer lines of code.
  • It's barely used.

Contributor guide

Research direction
Search for all uses of Loki types like Loki::Select and Loki::IsSameType in the codebase, then replace them with standard C++11 equivalents such as std::conditional and std::is same. For any Loki features not directly replaceable, consider implementing a minimal replacement or removing unused code.
Tech stack
ccpp
Domain
game dev
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++C++ templates
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40